Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issues reported by golangci-lint after bumping the version to v1.64.5 #19475

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Address issues reported by golangci-lint after bumping the version to v1.64.5 #19475

merged 1 commit into from
Feb 25, 2025
+59 −59

Conversation

henrybear327
Copy link
Contributor

@henrybear327 henrybear327 commented Feb 24, 2025 •
edited
Loading

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Resolving CI issues in #19466 (See this CI run for more detail)

@henrybear327 henrybear327 mentioned this pull request Feb 24, 2025
Open
@henrybear327 henrybear327 self-assigned this Feb 24, 2025
@henrybear327 henrybear327 requested review from ivanvc and ahrtr February 24, 2025 21:38
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (2de17bd) to head (43df62f).
Report is 9 commits behind head on main.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19475      +/-   ##
==========================================
+ Coverage   68.84%   68.89%   +0.04%     
==========================================
  Files         420      420              
  Lines       35762    35762              
==========================================
+ Hits        24622    24638      +16     
+ Misses       9714     9699      -15     
+ Partials     1426     1425       -1

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 022b9b2...43df62f. Read the comment docs.

@ivanvc
Copy link
Member

ivanvc commented Feb 24, 2025

/retest

ivanvc
ivanvc approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green. Thanks, @henrybear327.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, henrybear327, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 6d66d82 into etcd-io:main Feb 25, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvc ivanvc ivanvc approved these changes

@fuweid fuweid fuweid approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees

@henrybear327 henrybear327

Labels
approved area/testing size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@henrybear327 @ivanvc @k8s-ci-robot @fuweid @ahrtr